chore(deps): update dependency eslint to v9 (#452)

* chore(deps): update dependency eslint to v9

* chore: migrate eslint to v9

* fix: dependency issues

* fix: unit tests not working

* chore: disable lint check for Image component that does not work in ci

* fix: lint issue

---------

Co-authored-by: homarr-renovate[bot] <158783068+homarr-renovate[bot]@users.noreply.github.com>
Co-authored-by: Meier Lukas <meierschlumpf@gmail.com>

packages/api/eslint.config.js

@@ -0,0 +1,4 @@
+import baseConfig from "@homarr/eslint-config/base";
+
+/** @type {import('typescript-eslint').Config} */
+export default [...baseConfig];

packages/api/package.json

@@ -14,7 +14,7 @@
   "type": "module",
   "scripts": {
     "clean": "rm -rf .turbo node_modules",
-    "lint": "eslint .",
+    "lint": "eslint",
     "format": "prettier --check . --ignore-path ../../.gitignore",
     "typecheck": "tsc --noEmit"
   },
@@ -40,15 +40,9 @@
     "@homarr/prettier-config": "workspace:^0.1.0",
     "@homarr/tsconfig": "workspace:^0.1.0",
     "@types/dockerode": "^3.3.29",
-    "eslint": "^8.57.0",
+    "eslint": "^9.4.0",
     "prettier": "^3.3.1",
     "typescript": "^5.4.5"
   },
-  "eslintConfig": {
-    "root": true,
-    "extends": [
-      "@homarr/eslint-config/base"
-    ]
-  },
   "prettier": "@homarr/prettier-config"
 }

packages/api/src/router/docker/docker-router.ts

@@ -72,7 +72,7 @@ function sanitizeContainers(
 ): DockerContainer[] {
   return containers.map((container) => {
     return {
-      name: container.Names[0]?.split("/")[1] || "Unknown",
+      name: container.Names[0]?.split("/")[1] ?? "Unknown",
       id: container.Id,
       instance: container.instance,
       state: container.State as DockerContainerState,

packages/api/src/router/docker/docker-singleton.ts

@@ -28,7 +28,7 @@ export class DockerSingleton {
         host: `${host}:${ports[i]}`,
         instance: new Docker({
           host,
-          port: parseInt(ports[i] || "", 10),
+          port: parseInt(ports[i] ?? "", 10),
         }),
       });
       return instances;
@@ -41,6 +41,7 @@ export class DockerSingleton {
   }
 
   public static getInstance(): DockerInstance[] {
+    // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
     if (!DockerSingleton.instances) {
       DockerSingleton.instances = new DockerSingleton().createInstances();
     }

packages/api/src/router/group.ts

@@ -42,7 +42,7 @@ export const groupRouter = createTRPCRouter({
         ...group,
         members: group.members.map((member) => member.user),
       })),
-      totalCount: groupCount[0]!.count,
+      totalCount: groupCount[0]?.count ?? 0,
     };
   }),
   getById: protectedProcedure.input(validation.group.byId).query(async ({ input, ctx }) => {

packages/api/src/router/icons.ts

@@ -15,7 +15,7 @@ export const iconsRouter = createTRPCRouter({
               name: true,
               url: true,
             },
-            where: input.searchText?.length ?? 0 > 0 ? like(icons.name, `%${input.searchText}%`) : undefined,
+            where: (input.searchText?.length ?? 0) > 0 ? like(icons.name, `%${input.searchText}%`) : undefined,
             limit: 5,
           },
         },

packages/api/src/router/test/app.spec.ts

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-non-null-assertion */
 import { describe, expect, test, vi } from "vitest";
 
 import type { Session } from "@homarr/auth";

packages/api/src/router/test/group.spec.ts

@@ -169,7 +169,7 @@ describe("byId should return group by id including members and permissions", ()
     expect(result.id).toBe(groupId);
     expect(result.members.length).toBe(1);
 
-    const userKeys = Object.keys(result?.members[0] ?? {});
+    const userKeys = Object.keys(result.members[0] ?? {});
     expect(userKeys.length).toBe(4);
     expect(["id", "name", "email", "image"].some((key) => userKeys.includes(key)));
     expect(result.permissions.length).toBe(1);

packages/api/src/router/test/integration.spec.ts

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-non-null-assertion */
 import { describe, expect, it, vi } from "vitest";
 
 import type { Session } from "@homarr/auth";

packages/api/src/router/test/invite.spec.ts

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-non-null-assertion */
 import { describe, expect, test, vi } from "vitest";
 
 import type { Session } from "@homarr/auth";

packages/api/src/router/user.ts

@@ -44,13 +44,6 @@ export const userRouter = createTRPCRouter({
       });
     }
 
-    if (!dbInvite || dbInvite.expirationDate < new Date()) {
-      throw new TRPCError({
-        code: "FORBIDDEN",
-        message: "Invalid invite",
-      });
-    }
-
     await checkUsernameAlreadyTakenAndThrowAsync(ctx.db, input.username);
 
     await createUserAsync(ctx.db, input);

packages/api/src/router/widgets/weather.ts

@@ -18,7 +18,7 @@ export const weatherRouter = createTRPCRouter({
           maxTemp: weather.daily.temperature_2m_max[index],
           minTemp: weather.daily.temperature_2m_min[index],
         };
-      }) ?? [{ time: 0, weatherCode: 404 }],
+      }),
     };
   }),
 });

packages/api/src/trpc.ts

@@ -122,7 +122,7 @@ export const protectedProcedure = t.procedure.use(enforceUserIsAuthed);
 export const permissionRequiredProcedure = {
   requiresPermission: (permission: GroupPermissionKey) => {
     return protectedProcedure.use(({ ctx, input, next }) => {
-      if (!ctx.session?.user.permissions.includes(permission)) {
+      if (!ctx.session.user.permissions.includes(permission)) {
         throw new TRPCError({
           code: "FORBIDDEN",
           message: "Permission denied",