chore(deps): update dependency eslint to v9 (#452)

* chore(deps): update dependency eslint to v9

* chore: migrate eslint to v9

* fix: dependency issues

* fix: unit tests not working

* chore: disable lint check for Image component that does not work in ci

* fix: lint issue

---------

Co-authored-by: homarr-renovate[bot] <158783068+homarr-renovate[bot]@users.noreply.github.com>
Co-authored-by: Meier Lukas <meierschlumpf@gmail.com>

packages/auth/callbacks.ts

@@ -44,10 +44,8 @@ export const createSignInCallback =
   async ({ user }) => {
     if (!isCredentialsRequest) return true;
 
-    if (!user) return true;
-
     // https://github.com/nextauthjs/next-auth/issues/6106
-    if (!adapter?.createSession) {
+    if (!adapter.createSession) {
       return false;
     }
 
@@ -56,6 +54,7 @@ export const createSignInCallback =
 
     await adapter.createSession({
       sessionToken,
+      // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
       userId: user.id!,
       expires: sessionExpiry,
     });

packages/auth/eslint.config.js

@@ -0,0 +1,4 @@
+import baseConfig from "@homarr/eslint-config/base";
+
+/** @type {import('typescript-eslint').Config} */
+export default [...baseConfig];

packages/auth/package.json

@@ -16,7 +16,7 @@
   "license": "MIT",
   "scripts": {
     "clean": "rm -rf .turbo node_modules",
-    "lint": "eslint .",
+    "lint": "eslint",
     "format": "prettier --check . --ignore-path ../../.gitignore",
     "typecheck": "tsc --noEmit"
   },
@@ -40,15 +40,9 @@
     "@homarr/definitions": "workspace:^0.1.0",
     "@types/bcrypt": "5.0.2",
     "@types/cookies": "0.9.0",
-    "eslint": "^8.57.0",
+    "eslint": "^9.4.0",
     "prettier": "^3.3.1",
     "typescript": "^5.4.5"
   },
-  "eslintConfig": {
-    "root": true,
-    "extends": [
-      "@homarr/eslint-config/base"
-    ]
-  },
   "prettier": "@homarr/prettier-config"
 }

packages/auth/permissions/board-permissions.ts

@@ -23,14 +23,14 @@ export const constructBoardPermissions = (board: BoardPermissionsProps, session:
   const creatorId = "creator" in board ? board.creator?.id : board.creatorId;
 
   return {
-    hasFullAccess: session?.user?.id === creatorId || session?.user.permissions.includes("board-full-access"),
+    hasFullAccess: session?.user.id === creatorId || session?.user.permissions.includes("board-full-access"),
     hasChangeAccess:
-      session?.user?.id === creatorId ||
+      session?.user.id === creatorId ||
       board.userPermissions.some(({ permission }) => permission === "board-change") ||
       board.groupPermissions.some(({ permission }) => permission === "board-change") ||
       session?.user.permissions.includes("board-modify-all"),
     hasViewAccess:
-      session?.user?.id === creatorId ||
+      session?.user.id === creatorId ||
       board.userPermissions.length >= 1 ||
       board.groupPermissions.length >= 1 ||
       board.isPublic ||

packages/auth/test/callbacks.spec.ts

@@ -1,8 +1,9 @@
+/* eslint-disable @typescript-eslint/no-non-null-assertion */
 import type { ResponseCookie } from "next/dist/compiled/@edge-runtime/cookies";
 import type { ReadonlyRequestCookies } from "next/dist/server/web/spec-extension/adapters/request-cookies";
 import { cookies } from "next/headers";
 import type { Adapter, AdapterUser } from "@auth/core/adapters";
-import type { Account, User } from "next-auth";
+import type { Account } from "next-auth";
 import type { JWT } from "next-auth/jwt";
 import { describe, expect, it, test, vi } from "vitest";
 
@@ -141,21 +142,11 @@ describe("createSignInCallback", () => {
     expect(result).toBe(true);
   });
 
-  it("should return true if no user", async () => {
-    const isCredentialsRequest = true;
-    const signInCallback = createSignInCallback(createAdapter(), isCredentialsRequest);
-    const result = await signInCallback({
-      user: undefined as unknown as User,
-      account: {} as Account,
-    });
-    expect(result).toBe(true);
-  });
-
   it("should return false if no adapter.createSession", async () => {
     const isCredentialsRequest = true;
     const signInCallback = createSignInCallback(
       // https://github.com/nextauthjs/next-auth/issues/6106
-      undefined as unknown as Adapter,
+      { createSession: undefined } as unknown as Adapter,
       isCredentialsRequest,
     );
     const result = await signInCallback({