chore(deps): update dependency eslint to v9 (#452)

* chore(deps): update dependency eslint to v9

* chore: migrate eslint to v9

* fix: dependency issues

* fix: unit tests not working

* chore: disable lint check for Image component that does not work in ci

* fix: lint issue

---------

Co-authored-by: homarr-renovate[bot] <158783068+homarr-renovate[bot]@users.noreply.github.com>
Co-authored-by: Meier Lukas <meierschlumpf@gmail.com>

packages/modals/eslint.config.js

@@ -0,0 +1,5 @@
+import baseConfig from "@homarr/eslint-config/base";
+import reactConfig from "@homarr/eslint-config/react";
+
+/** @type {import('typescript-eslint').Config} */
+export default [...baseConfig, ...reactConfig];

packages/modals/package.json

@@ -2,6 +2,7 @@
   "name": "@homarr/modals",
   "private": true,
   "version": "0.1.0",
+  "type": "module",
   "exports": {
     ".": "./index.ts"
   },
@@ -15,7 +16,7 @@
   "license": "MIT",
   "scripts": {
     "clean": "rm -rf .turbo node_modules",
-    "lint": "eslint .",
+    "lint": "eslint",
     "format": "prettier --check . --ignore-path ../../.gitignore",
     "typecheck": "tsc --noEmit"
   },
@@ -27,13 +28,8 @@
     "@homarr/eslint-config": "workspace:^0.2.0",
     "@homarr/prettier-config": "workspace:^0.1.0",
     "@homarr/tsconfig": "workspace:^0.1.0",
-    "eslint": "^8.57.0",
+    "eslint": "^9.4.0",
     "typescript": "^5.4.5"
   },
-  "eslintConfig": {
-    "extends": [
-      "@homarr/eslint-config/base"
-    ]
-  },
   "prettier": "@homarr/prettier-config"
 }

packages/modals/src/confirm-modal.tsx

@@ -41,7 +41,7 @@ export const ConfirmModal = createModal<Omit<ConfirmModalProps, "title">>(({ act
 
   const handleCancel = useCallback(
     async (event: React.MouseEvent<HTMLButtonElement>) => {
-      typeof cancelProps?.onClick === "function" && cancelProps?.onClick(event);
+      typeof cancelProps?.onClick === "function" && cancelProps.onClick(event);
       typeof onCancel === "function" && (await onCancel());
       closeOnCancel && actions.closeModal();
     },
@@ -51,7 +51,7 @@ export const ConfirmModal = createModal<Omit<ConfirmModalProps, "title">>(({ act
   const handleConfirm = useCallback(
     async (event: React.MouseEvent<HTMLButtonElement>) => {
       setLoading(true);
-      typeof confirmProps?.onClick === "function" && confirmProps?.onClick(event);
+      typeof confirmProps?.onClick === "function" && confirmProps.onClick(event);
       typeof onConfirm === "function" && (await onConfirm());
       closeOnConfirm && actions.closeModal();
       setLoading(false);
@@ -65,11 +65,11 @@ export const ConfirmModal = createModal<Omit<ConfirmModalProps, "title">>(({ act
 
       <Group justify="flex-end" {...groupProps}>
         <Button variant="default" {...cancelProps} onClick={handleCancel}>
-          {cancelProps?.children || translateIfNecessary(t, cancelLabel)}
+          {cancelProps?.children ?? translateIfNecessary(t, cancelLabel)}
         </Button>
 
         <Button {...confirmProps} onClick={handleConfirm} color="red.9" loading={loading}>
-          {confirmProps?.children || translateIfNecessary(t, confirmLabel)}
+          {confirmProps?.children ?? translateIfNecessary(t, confirmLabel)}
         </Button>
       </Group>
     </>

packages/modals/src/index.tsx

@@ -138,6 +138,8 @@ export const useModalAction = <TModal extends ModalDefinition>(modal: TModal) =>
 
   return {
     openModal: (innerProps: inferInnerProps<TModal>, options: OpenModalOptions | void) => {
+      // void actually is undefined
+      // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
       context.openModalInner({ modal, innerProps, options: options ?? {} });
     },
   };

packages/modals/src/reducer.tsx

@@ -62,7 +62,7 @@ export const modalReducer = (state: ModalsState, action: OpenAction | CloseActio
       const remainingModals = state.modals.filter((modal) => modal.id !== action.modalId);
 
       return {
-        current: remainingModals[remainingModals.length - 1] || state.current,
+        current: remainingModals[remainingModals.length - 1] ?? state.current,
         modals: remainingModals,
       };
     }