fix(update-checker): cached through updates (#4046)

apps/tasks/src/job-manager.ts

@@ -26,7 +26,6 @@ export class JobManager implements IJobManager {
     logger.info(`Updating cron job interval name="${name}" expression="${cron}"`);
     const job = this.jobGroup.getJobRegistry().get(name);
     if (!job) throw new Error(`Job ${name} not found`);
-    if (job.cronExpression === "never") throw new Error(`Job ${name} cannot be updated as it is set to "never"`);
     if (!validateCron(cron)) {
       throw new Error(`Invalid cron expression: ${cron}`);
     }
@@ -45,7 +44,6 @@ export class JobManager implements IJobManager {
     logger.info(`Disabling cron job name="${name}"`);
     const job = this.jobGroup.getJobRegistry().get(name);
     if (!job) throw new Error(`Job ${name} not found`);
-    if (job.cronExpression === "never") throw new Error(`Job ${name} cannot be disabled as it is set to "never"`);
 
     await this.updateConfigurationAsync(name, { isEnabled: false });
     await this.jobGroup.stopAsync(name);

apps/tasks/src/main.ts

@@ -13,6 +13,7 @@ import { db } from "@homarr/db";
 import { logger } from "@homarr/log";
 
 import { JobManager } from "./job-manager";
+import { onStartAsync } from "./on-start";
 
 const server = fastify({
   maxParamLength: 5000,
@@ -32,6 +33,7 @@ server.register(fastifyTRPCPlugin, {
 });
 
 void (async () => {
+  await onStartAsync();
   await jobGroup.initializeAsync();
   await jobGroup.startAllAsync();
 

apps/tasks/src/on-start/index.ts

@@ -0,0 +1,7 @@
+import { invalidateUpdateCheckerCacheAsync } from "./invalidate-update-checker-cache";
+import { cleanupSessionsAsync } from "./session-cleanup";
+
+export async function onStartAsync() {
+  await cleanupSessionsAsync();
+  await invalidateUpdateCheckerCacheAsync();
+}

apps/tasks/src/on-start/invalidate-update-checker-cache.ts

@@ -0,0 +1,18 @@
+import { logger } from "@homarr/log";
+import { updateCheckerRequestHandler } from "@homarr/request-handler/update-checker";
+
+const localLogger = logger.child({ module: "invalidateUpdateCheckerCache" });
+
+/**
+ * Invalidates the update checker cache on startup to ensure fresh data.
+ * It is important as we want to avoid showing pending updates after the update to latest version.
+ */
+export async function invalidateUpdateCheckerCacheAsync() {
+  try {
+    const handler = updateCheckerRequestHandler.handler({});
+    await handler.invalidateAsync();
+    localLogger.debug("Update checker cache invalidated");
+  } catch (error) {
+    localLogger.error(new Error("Failed to invalidate update checker cache", { cause: error }));
+  }
+}

apps/tasks/src/on-start/session-cleanup.ts

@@ -0,0 +1,39 @@
+import { env } from "@homarr/auth/env";
+import { db, eq, inArray } from "@homarr/db";
+import { sessions, users } from "@homarr/db/schema";
+import { supportedAuthProviders } from "@homarr/definitions";
+import { logger } from "@homarr/log";
+
+const localLogger = logger.child({ module: "sessionCleanup" });
+
+/**
+ * Deletes sessions for users that have inactive auth providers.
+ * Sessions from other providers are deleted so they can no longer be used.
+ */
+export async function cleanupSessionsAsync() {
+  try {
+    const currentAuthProviders = env.AUTH_PROVIDERS;
+
+    const inactiveAuthProviders = supportedAuthProviders.filter((provider) => !currentAuthProviders.includes(provider));
+    const subQuery = db
+      .select({ id: users.id })
+      .from(users)
+      .where(inArray(users.provider, inactiveAuthProviders))
+      .as("sq");
+    const sessionsWithInactiveProviders = await db
+      .select({ userId: sessions.userId })
+      .from(sessions)
+      .rightJoin(subQuery, eq(sessions.userId, subQuery.id));
+
+    const userIds = sessionsWithInactiveProviders.map(({ userId }) => userId).filter((value) => value !== null);
+    await db.delete(sessions).where(inArray(sessions.userId, userIds));
+
+    if (sessionsWithInactiveProviders.length > 0) {
+      localLogger.info(`Deleted sessions for inactive providers count=${userIds.length}`);
+    } else {
+      localLogger.debug("No sessions to delete");
+    }
+  } catch (error) {
+    localLogger.error(new Error("Failed to clean up sessions", { cause: error }));
+  }
+}