jazzymc/homarr
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix: when removing one item and then adding another one that newly added one can not be moved (#1025)

Browse Source 
* fix: when removing one item and then adding another one that newly added one can not be moved

* chore: address pull request feedback

* fix: deepsource canceled
This commit is contained in:
Meier Lukas
2024-08-29 22:26:02 +02:00
committed by GitHub
parent 94984ac11b
commit 2738f40c5e
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
apps/nextjs/src/components/board/sections/gridstack/use-gridstack.ts
View File

@@ -80,8 +80,16 @@ export const useGridstack = (section: Omit<Section, "items">, itemIds: string[])
isDynamic: section.kind === "dynamic", isDynamic: section.kind === "dynamic",
}); });
const itemRefKeys = Object.keys(itemRefs.current);
// define items in itemRefs for easy access and reference to items // define items in itemRefs for easy access and reference to items
if (Object.keys(itemRefs.current).length !== itemIds.length) { if (itemRefKeys.length !== itemIds.length) {
// Remove items that are not in the itemIds
// Otherwise when an item is removed and then another item is added, this foreach below will not run.
itemRefKeys.forEach((id) => {
if (!itemIds.includes(id)) {
delete itemRefs.current[id];
}
});
itemIds.forEach((id) => { itemIds.forEach((id) => {
itemRefs.current[id] = itemRefs.current[id] ?? createRef(); itemRefs.current[id] = itemRefs.current[id] ?? createRef();
}); });