From 5dc5d9e04ab747655276494d70557b45fed87b2c Mon Sep 17 00:00:00 2001
From: Manuel <30572287+manuel-rw@users.noreply.github.com>
Date: Sun, 23 Feb 2025 12:34:04 +0100
Subject: [PATCH] fix: omv invalid temperature when not available (#2322)

---
 .run/typecheck.run.xml                              | 13 +++++++++++++
 .../health-monitoring/healt-monitoring.ts           |  2 +-
 .../src/openmediavault/openmediavault-types.ts      |  2 +-
 .../widgets/src/health-monitoring/system-health.tsx |  5 ++---
 4 files changed, 17 insertions(+), 5 deletions(-)
 create mode 100644 .run/typecheck.run.xml

diff --git a/.run/typecheck.run.xml b/.run/typecheck.run.xml
new file mode 100644
index 000000000..c3c228ae5
--- /dev/null
+++ b/.run/typecheck.run.xml
@@ -0,0 +1,13 @@
+<component name="ProjectRunConfigurationManager">
+  <configuration default="false" name="typecheck" type="js.build_tools.npm">
+    <package-json value="$PROJECT_DIR$/package.json" />
+    <command value="run" />
+    <scripts>
+      <script value="typecheck" />
+    </scripts>
+    <node-interpreter value="project" />
+    <package-manager value="pnpm" />
+    <envs />
+    <method v="2" />
+  </configuration>
+</component>
\ No newline at end of file
diff --git a/packages/integrations/src/interfaces/health-monitoring/healt-monitoring.ts b/packages/integrations/src/interfaces/health-monitoring/healt-monitoring.ts
index f991f31c5..90b2b8013 100644
--- a/packages/integrations/src/interfaces/health-monitoring/healt-monitoring.ts
+++ b/packages/integrations/src/interfaces/health-monitoring/healt-monitoring.ts
@@ -21,7 +21,7 @@ export interface HealthMonitoring {
   }[];
   smart: {
     deviceName: string;
-    temperature: number;
+    temperature: number | null;
     overallStatus: string;
   }[];
 }
diff --git a/packages/integrations/src/openmediavault/openmediavault-types.ts b/packages/integrations/src/openmediavault/openmediavault-types.ts
index f9512ce66..74b35bf6c 100644
--- a/packages/integrations/src/openmediavault/openmediavault-types.ts
+++ b/packages/integrations/src/openmediavault/openmediavault-types.ts
@@ -40,7 +40,7 @@ export const smartSchema = z.object({
         // Convert string to number if necessary
         const temp = typeof val === "string" ? parseFloat(val) : val;
         if (isNaN(temp)) {
-          throw new Error("Invalid temperature value");
+          return null;
         }
         return temp;
       }),
diff --git a/packages/widgets/src/health-monitoring/system-health.tsx b/packages/widgets/src/health-monitoring/system-health.tsx
index 5831a2106..d081132f9 100644
--- a/packages/widgets/src/health-monitoring/system-health.tsx
+++ b/packages/widgets/src/health-monitoring/system-health.tsx
@@ -64,12 +64,11 @@ export const SystemHealthMonitoring = ({ options, integrationIds }: WidgetCompon
           if (!prevData) {
             return undefined;
           }
-          const newData = prevData.map((item) =>
+          return prevData.map((item) =>
             item.integrationId === data.integrationId
               ? { ...item, healthInfo: data.healthInfo, updatedAt: data.timestamp }
               : item,
           );
-          return newData;
         });
       },
     },
@@ -294,7 +293,7 @@ interface FileSystem {
 
 interface SmartData {
   deviceName: string;
-  temperature: number;
+  temperature: number | null;
   overallStatus: string;
 }