feat: add job on start option for icons updater (#442)

apps/tasks/src/jobs/icons-updater.ts

@@ -8,9 +8,10 @@ import { logger } from "@homarr/log";
 import { EVERY_WEEK } from "~/lib/cron-job/constants";
 import { createCronJob } from "~/lib/cron-job/creator";
 
-export const iconsUpdaterJob = createCronJob(EVERY_WEEK).withCallback(
-  async () => {
-    logger.info(`Updating icon repository cache...`);
+export const iconsUpdaterJob = createCronJob(EVERY_WEEK, {
+  runOnStart: true,
+}).withCallback(async () => {
+  logger.info("Updating icon repository cache...");
   const stopWatch = new Stopwatch();
   const repositoryIconGroups = await fetchIconsAsync();
   const countIcons = repositoryIconGroups
@@ -30,7 +31,7 @@ export const iconsUpdaterJob = createCronJob(EVERY_WEEK).withCallback(
   let countDeleted = 0;
   let countInserted = 0;
 
-    logger.info(`Updating icons in database...`);
+  logger.info("Updating icons in database...");
   stopWatch.reset();
 
   await db.transaction(async (transaction) => {
@@ -54,7 +55,7 @@ export const iconsUpdaterJob = createCronJob(EVERY_WEEK).withCallback(
         if (
           databaseIconGroups
             .flatMap((group) => group.icons)
-              .some((dbIcon) => dbIcon.checksum == icon.checksum)
+            .some((dbIcon) => dbIcon.checksum === icon.checksum)
         ) {
           skippedChecksums.push(icon.checksum);
           continue;
@@ -76,9 +77,7 @@ export const iconsUpdaterJob = createCronJob(EVERY_WEEK).withCallback(
       .filter((icon) => !skippedChecksums.includes(icon.checksum));
 
     for (const icon of deadIcons) {
-        await transaction
-          .delete(icons)
-          .where(eq(icons.checksum, icon.checksum));
+      await transaction.delete(icons).where(eq(icons.checksum, icon.checksum));
       countDeleted++;
     }
   });
@@ -86,5 +85,4 @@ export const iconsUpdaterJob = createCronJob(EVERY_WEEK).withCallback(
   logger.info(
     `Updated database within ${stopWatch.getElapsedInHumanWords()} (-${countDeleted}, +${countInserted})`,
   );
-  },
-);
+});

apps/tasks/src/lib/cron-job/creator.ts

@@ -2,9 +2,20 @@ import cron from "node-cron";
 
 import type { MaybePromise } from "@homarr/common/types";
 
-export const createCronJob = (cronExpression: string) => {
+interface CreateCronJobOptions {
+  runOnStart?: boolean;
+}
+
+export const createCronJob = (
+  cronExpression: string,
+  options: CreateCronJobOptions = { runOnStart: false },
+) => {
   return {
     withCallback: (callback: () => MaybePromise<void>) => {
+      if (options.runOnStart) {
+        void callback();
+      }
+
       const task = cron.schedule(cronExpression, () => void callback(), {
         scheduled: false,
       });