fix: memory leak caused by many unclosed redis subscriptions (#750)

* fix: memory leak caused by many unclosed redis subscriptions * chore: address pull request feedback
2024-07-07 09:58:20 +02:00
parent 61cbb74d14
commit 998615fc11
7 changed files with 114 additions and 44 deletions
--- a/packages/api/src/router/widgets/smart-home.ts
+++ b/packages/api/src/router/widgets/smart-home.ts
@@ -13,10 +13,7 @@ export const smartHomeRouter = createTRPCRouter({
      entityId: string;
      state: string;
    }>((emit) => {
-      let isConnectionClosed = false;
-
-      homeAssistantEntityState.subscribe((message) => {
-        if (isConnectionClosed) return;
+      const unsubscribe = homeAssistantEntityState.subscribe((message) => {
        if (message.entityId !== input.entityId) {
          return;
        }
@@ -24,7 +21,7 @@ export const smartHomeRouter = createTRPCRouter({
      });

      return () => {
-        isConnectionClosed = true;
+        unsubscribe();
      };
    });
  }),