From a4f6a7c16a4de8adb758812356e947d88c5a5e35 Mon Sep 17 00:00:00 2001
From: "deepsource-autofix[bot]"
 <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Date: Thu, 8 Feb 2024 20:06:57 +0100
Subject: [PATCH] refactor: replace short hand type conversions with function
 calls (#65)

* refactor: replace short hand type conversions with function calls

Prefer using explicit casts by calling `Number`, `Boolean`, or `String` over using operators like `+`, `!!` or `"" +`. This is considered best practice as it improves readability.

* fix: formatting

---------

Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Co-authored-by: Meier Lukas <meierschlumpf@gmail.com>
---
 apps/nextjs/src/env.mjs                | 4 ++--
 packages/api/src/router/integration.ts | 2 +-
 packages/auth/env.mjs                  | 3 ++-
 3 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/apps/nextjs/src/env.mjs b/apps/nextjs/src/env.mjs
index f098ee199..c4d2d4e1e 100644
--- a/apps/nextjs/src/env.mjs
+++ b/apps/nextjs/src/env.mjs
@@ -33,7 +33,7 @@ export const env = createEnv({
     // NEXT_PUBLIC_CLIENTVAR: process.env.NEXT_PUBLIC_CLIENTVAR,
   },
   skipValidation:
-    !!process.env.CI ||
-    !!process.env.SKIP_ENV_VALIDATION ||
+    Boolean(process.env.CI) ||
+    Boolean(process.env.SKIP_ENV_VALIDATION) ||
     process.env.npm_lifecycle_event === "lint",
 });
diff --git a/packages/api/src/router/integration.ts b/packages/api/src/router/integration.ts
index 1cfe85cca..16018aec3 100644
--- a/packages/api/src/router/integration.ts
+++ b/packages/api/src/router/integration.ts
@@ -165,7 +165,7 @@ export const integrationRouter = createTRPCRouter({
       const secretKinds = getSecretKinds(input.kind);
       const secrets = input.secrets.filter(
         (secret): secret is { kind: IntegrationSecretKind; value: string } =>
-          !!secret.value,
+          Boolean(secret.value),
       );
       const everyInputSecretDefined = secretKinds.every((secretKind) =>
         secrets.some((secret) => secret.kind === secretKind),
diff --git a/packages/auth/env.mjs b/packages/auth/env.mjs
index 2866529a5..9c260510b 100644
--- a/packages/auth/env.mjs
+++ b/packages/auth/env.mjs
@@ -20,5 +20,6 @@ export const env = createEnv({
     AUTH_SECRET: process.env.AUTH_SECRET,
     AUTH_URL: process.env.AUTH_URL,
   },
-  skipValidation: !!process.env.CI || !!process.env.SKIP_ENV_VALIDATION,
+  skipValidation:
+    Boolean(process.env.CI) || Boolean(process.env.SKIP_ENV_VALIDATION),
 });