refactor(logs): move to core package (#4586)

apps/tasks/src/job-manager.ts

@@ -1,11 +1,13 @@
 import { schedule, validate as validateCron } from "node-cron";
 
+import { createLogger } from "@homarr/core/infrastructure/logs";
 import type { IJobManager } from "@homarr/cron-job-api";
 import type { jobGroup as cronJobGroup, JobGroupKeys } from "@homarr/cron-jobs";
 import type { Database, InferInsertModel } from "@homarr/db";
 import { eq } from "@homarr/db";
 import { cronJobConfigurations } from "@homarr/db/schema";
-import { logger } from "@homarr/log";
+
+const logger = createLogger({ module: "jobManager" });
 
 export class JobManager implements IJobManager {
   constructor(
@@ -23,7 +25,7 @@ export class JobManager implements IJobManager {
     await this.jobGroup.stopAsync(name);
   }
   public async updateIntervalAsync(name: JobGroupKeys, cron: string): Promise<void> {
-    logger.info(`Updating cron job interval name="${name}" expression="${cron}"`);
+    logger.info("Updating cron job interval", { name, expression: cron });
     const job = this.jobGroup.getJobRegistry().get(name);
     if (!job) throw new Error(`Job ${name} not found`);
     if (!validateCron(cron)) {
@@ -38,22 +40,22 @@ export class JobManager implements IJobManager {
         name,
       }),
     );
-    logger.info(`Cron job interval updated name="${name}" expression="${cron}"`);
+    logger.info("Cron job interval updated", { name, expression: cron });
   }
   public async disableAsync(name: JobGroupKeys): Promise<void> {
-    logger.info(`Disabling cron job name="${name}"`);
+    logger.info("Disabling cron job", { name });
     const job = this.jobGroup.getJobRegistry().get(name);
     if (!job) throw new Error(`Job ${name} not found`);
 
     await this.updateConfigurationAsync(name, { isEnabled: false });
     await this.jobGroup.stopAsync(name);
-    logger.info(`Cron job disabled name="${name}"`);
+    logger.info("Cron job disabled", { name });
   }
   public async enableAsync(name: JobGroupKeys): Promise<void> {
-    logger.info(`Enabling cron job name="${name}"`);
+    logger.info("Enabling cron job", { name });
     await this.updateConfigurationAsync(name, { isEnabled: true });
     await this.jobGroup.startAsync(name);
-    logger.info(`Cron job enabled name="${name}"`);
+    logger.info("Cron job enabled", { name });
   }
 
   private async updateConfigurationAsync(
@@ -64,9 +66,11 @@ export class JobManager implements IJobManager {
       where: (table, { eq }) => eq(table.name, name),
     });
 
-    logger.debug(
-      `Updating cron job configuration name="${name}" configuration="${JSON.stringify(configuration)}" exists="${Boolean(existingConfig)}"`,
-    );
+    logger.debug("Updating cron job configuration", {
+      name,
+      configuration: JSON.stringify(configuration),
+      exists: Boolean(existingConfig),
+    });
 
     if (existingConfig) {
       await this.db
@@ -74,7 +78,10 @@ export class JobManager implements IJobManager {
         // prevent updating the name, as it is the primary key
         .set({ ...configuration, name: undefined })
         .where(eq(cronJobConfigurations.name, name));
-      logger.debug(`Cron job configuration updated name="${name}" configuration="${JSON.stringify(configuration)}"`);
+      logger.debug("Cron job configuration updated", {
+        name,
+        configuration: JSON.stringify(configuration),
+      });
       return;
     }
 
@@ -86,7 +93,10 @@ export class JobManager implements IJobManager {
       cronExpression: configuration.cronExpression ?? job.cronExpression,
       isEnabled: configuration.isEnabled ?? true,
     });
-    logger.debug(`Cron job configuration updated name="${name}" configuration="${JSON.stringify(configuration)}"`);
+    logger.debug("Cron job configuration updated", {
+      name,
+      configuration: JSON.stringify(configuration),
+    });
   }
 
   public async getAllAsync(): Promise<

apps/tasks/src/main.ts

@@ -5,16 +5,19 @@ import type { FastifyTRPCPluginOptions } from "@trpc/server/adapters/fastify";
 import { fastifyTRPCPlugin } from "@trpc/server/adapters/fastify";
 import fastify from "fastify";
 
+import { createLogger } from "@homarr/core/infrastructure/logs";
+import { ErrorWithMetadata } from "@homarr/core/infrastructure/logs/error";
 import type { JobRouter } from "@homarr/cron-job-api";
 import { jobRouter } from "@homarr/cron-job-api";
 import { CRON_JOB_API_KEY_HEADER, CRON_JOB_API_PATH, CRON_JOB_API_PORT } from "@homarr/cron-job-api/constants";
 import { jobGroup } from "@homarr/cron-jobs";
 import { db } from "@homarr/db";
-import { logger } from "@homarr/log";
 
 import { JobManager } from "./job-manager";
 import { onStartAsync } from "./on-start";
 
+const logger = createLogger({ module: "tasksMain" });
+
 const server = fastify({
   maxParamLength: 5000,
 });
@@ -27,7 +30,7 @@ server.register(fastifyTRPCPlugin, {
       apiKey: req.headers[CRON_JOB_API_KEY_HEADER] as string | undefined,
     }),
     onError({ path, error }) {
-      logger.error(new Error(`Error in tasks tRPC handler path="${path}"`, { cause: error }));
+      logger.error(new ErrorWithMetadata("Error in tasks tRPC handler", { path }, { cause: error }));
     },
   } satisfies FastifyTRPCPluginOptions<JobRouter>["trpcOptions"],
 });
@@ -39,9 +42,11 @@ void (async () => {
 
   try {
     await server.listen({ port: CRON_JOB_API_PORT });
-    logger.info(`Tasks web server started successfully port="${CRON_JOB_API_PORT}"`);
+    logger.info("Tasks web server started successfully", { port: CRON_JOB_API_PORT });
   } catch (err) {
-    logger.error(new Error(`Failed to start tasks web server port="${CRON_JOB_API_PORT}"`, { cause: err }));
+    logger.error(
+      new ErrorWithMetadata("Failed to start tasks web server", { port: CRON_JOB_API_PORT }, { cause: err }),
+    );
     process.exit(1);
   }
 })();

apps/tasks/src/on-start/invalidate-update-checker-cache.ts

@@ -1,7 +1,7 @@
-import { logger } from "@homarr/log";
+import { createLogger } from "@homarr/core/infrastructure/logs";
 import { updateCheckerRequestHandler } from "@homarr/request-handler/update-checker";
 
-const localLogger = logger.child({ module: "invalidateUpdateCheckerCache" });
+const logger = createLogger({ module: "invalidateUpdateCheckerCache" });
 
 /**
  * Invalidates the update checker cache on startup to ensure fresh data.
@@ -11,8 +11,8 @@ export async function invalidateUpdateCheckerCacheAsync() {
   try {
     const handler = updateCheckerRequestHandler.handler({});
     await handler.invalidateAsync();
-    localLogger.debug("Update checker cache invalidated");
+    logger.debug("Update checker cache invalidated");
   } catch (error) {
-    localLogger.error(new Error("Failed to invalidate update checker cache", { cause: error }));
+    logger.error(new Error("Failed to invalidate update checker cache", { cause: error }));
   }
 }

apps/tasks/src/on-start/session-cleanup.ts

@@ -1,10 +1,10 @@
 import { env } from "@homarr/auth/env";
+import { createLogger } from "@homarr/core/infrastructure/logs";
 import { db, eq, inArray } from "@homarr/db";
 import { sessions, users } from "@homarr/db/schema";
 import { supportedAuthProviders } from "@homarr/definitions";
-import { logger } from "@homarr/log";
 
-const localLogger = logger.child({ module: "sessionCleanup" });
+const logger = createLogger({ module: "sessionCleanup" });
 
 /**
  * Deletes sessions for users that have inactive auth providers.
@@ -29,11 +29,13 @@ export async function cleanupSessionsAsync() {
     await db.delete(sessions).where(inArray(sessions.userId, userIds));
 
     if (sessionsWithInactiveProviders.length > 0) {
-      localLogger.info(`Deleted sessions for inactive providers count=${userIds.length}`);
+      logger.info("Deleted sessions for inactive providers", {
+        count: userIds.length,
+      });
     } else {
-      localLogger.debug("No sessions to delete");
+      logger.debug("No sessions to delete");
     }
   } catch (error) {
-    localLogger.error(new Error("Failed to clean up sessions", { cause: error }));
+    logger.error(new Error("Failed to clean up sessions", { cause: error }));
   }
 }