fix: empty env variables should be ignored (#2040)

* fix: empty env variables should be ignored

* fix: e2e test fails because of empty env variable values

apps/nextjs/src/env.ts

@@ -35,4 +35,5 @@ export const env = createEnv({
     // NEXT_PUBLIC_CLIENTVAR: process.env.NEXT_PUBLIC_CLIENTVAR,
   },
   skipValidation: shouldSkipEnvValidation(),
+  emptyStringAsUndefined: true,
 });

e2e/onboarding.spec.ts

@@ -49,9 +49,9 @@ describe("Onboarding", () => {
       environment: {
         AUTH_PROVIDERS: "ldap",
         AUTH_LDAP_URI: "ldap://host.docker.internal:3890",
-        AUTH_LDAP_BASE: "",
-        AUTH_LDAP_BIND_DN: "",
-        AUTH_LDAP_BIND_PASSWORD: "",
+        AUTH_LDAP_BASE: "not-used",
+        AUTH_LDAP_BIND_DN: "not-used",
+        AUTH_LDAP_BIND_PASSWORD: "not-used",
       },
       mounts: {
         "/appdata": localMountPath,

packages/auth/env.ts

@@ -86,4 +86,5 @@ export const env = createEnv({
     AUTH_OIDC_NAME_ATTRIBUTE_OVERWRITE: process.env.AUTH_OIDC_NAME_ATTRIBUTE_OVERWRITE,
   },
   skipValidation,
+  emptyStringAsUndefined: true,
 });

packages/common/env.ts

@@ -26,4 +26,5 @@ export const env = createEnv({
     SECRET_ENCRYPTION_KEY: process.env.SECRET_ENCRYPTION_KEY,
   },
   skipValidation: shouldSkipEnvValidation(),
+  emptyStringAsUndefined: true,
 });

packages/db/env.ts

@@ -27,7 +27,11 @@ export const env = createEnv({
       .default(drivers.betterSqlite3),
     ...(urlRequired
       ? {
-          DB_URL: z.string(),
+          DB_URL:
+            // Fallback to the default sqlite file path in production
+            process.env.NODE_ENV === "production" && isDriver("better-sqlite3")
+              ? z.string().default("/appdata/db/db.sqlite")
+              : z.string().nonempty(),
         }
       : {}),
     ...(hostRequired
@@ -58,4 +62,5 @@ export const env = createEnv({
     DB_PORT: process.env.DB_PORT,
   },
   skipValidation: shouldSkipEnvValidation(),
+  emptyStringAsUndefined: true,
 });