jazzymc/homarr
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

refactor: replace short hand type conversions with function calls (#65)

Browse Source 
* refactor: replace short hand type conversions with function calls

Prefer using explicit casts by calling `Number`, `Boolean`, or `String` over using operators like `+`, `!!` or `"" +`. This is considered best practice as it improves readability.

* fix: formatting

---------

Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Co-authored-by: Meier Lukas <meierschlumpf@gmail.com>
This commit is contained in:
deepsource-autofix[bot]
2024-02-08 20:06:57 +01:00
committed by GitHub
parent 11d1568714
commit a4f6a7c16a
3 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
apps/nextjs/src/env.mjs
View File

@@ -33,7 +33,7 @@ export const env = createEnv({
// NEXT_PUBLIC_CLIENTVAR: process.env.NEXT_PUBLIC_CLIENTVAR, // NEXT_PUBLIC_CLIENTVAR: process.env.NEXT_PUBLIC_CLIENTVAR,
}, },
skipValidation: skipValidation:
!!process.env.CI || Boolean(process.env.CI) ||
!!process.env.SKIP_ENV_VALIDATION || Boolean(process.env.SKIP_ENV_VALIDATION) ||
process.env.npm_lifecycle_event === "lint", process.env.npm_lifecycle_event === "lint",
}); });

2
packages/api/src/router/integration.ts
View File

@@ -165,7 +165,7 @@ export const integrationRouter = createTRPCRouter({
const secretKinds = getSecretKinds(input.kind); const secretKinds = getSecretKinds(input.kind);
const secrets = input.secrets.filter( const secrets = input.secrets.filter(
(secret): secret is { kind: IntegrationSecretKind; value: string } => (secret): secret is { kind: IntegrationSecretKind; value: string } =>
!!secret.value, Boolean(secret.value),
); );
const everyInputSecretDefined = secretKinds.every((secretKind) => const everyInputSecretDefined = secretKinds.every((secretKind) =>
secrets.some((secret) => secret.kind === secretKind), secrets.some((secret) => secret.kind === secretKind),

3
packages/auth/env.mjs
View File

@@ -20,5 +20,6 @@ export const env = createEnv({
AUTH_SECRET: process.env.AUTH_SECRET, AUTH_SECRET: process.env.AUTH_SECRET,
AUTH_URL: process.env.AUTH_URL, AUTH_URL: process.env.AUTH_URL,
}, },
skipValidation: !!process.env.CI || !!process.env.SKIP_ENV_VALIDATION, skipValidation:
Boolean(process.env.CI) || Boolean(process.env.SKIP_ENV_VALIDATION),
}); });